Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyTorch Hub classification CI checks #9027

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Add PyTorch Hub classification CI checks #9027

merged 2 commits into from
Aug 18, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Aug 18, 2022

Add PyTorch Hub loading of official and custom trained classification models to CI checks.

May help resolve #8790 (comment)

Signed-off-by: Glenn Jocher glenn.jocher@ultralytics.com

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Enhanced integration with torch.hub and internal refactoring for model handling.

📊 Key Changes

  • Added a code snippet to ci-testing.yml for verifying torch.hub integration.
  • Renamed Model class to DetectionModel for clarity within hubconf.py.
  • Updated relevant instances where Model was used to the new DetectionModel name.
  • Ensured that AutoShape is only applied to instances of DetectionModel.

🎯 Purpose & Impact

  • 🛠 Purpose: The update aims to improve the ease of loading YOLOv5 models directly from a local source using torch.hub and to make internal code more descriptive.
  • 🚀 Impact: Users will experience more reliable model loading through code, and developers will find it easier to understand and maintain the underlying codebase.

Add PyTorch Hub loading of official and custom trained classification models to CI checks. 

May help resolve #8790 (comment)

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher self-assigned this Aug 18, 2022
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher merged commit eb359c3 into master Aug 18, 2022
@glenn-jocher glenn-jocher deleted the update/ci branch August 18, 2022 19:45
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
* Add PyTorch Hub classification CI checks

Add PyTorch Hub loading of official and custom trained classification models to CI checks. 

May help resolve ultralytics#8790 (comment)

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

* Update hubconf.py

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How can I move and run the classification model out of YOLOV5 codebase?
1 participant